Dropdown: Add ability to open via space bar - #1466
Merged
Micah Godbolt (micahgodbolt) merged 4 commits intoApr 11, 2017
Merged
Conversation
Note that unlike for other keys, we handle the open/close in onKeyUp to prevent double triggering of the event. Resolves #1445
Micah Godbolt (micahgodbolt)
self-requested a review
April 11, 2017 17:52
Member
|
Works great for me. |
Micah Godbolt (micahgodbolt)
approved these changes
Apr 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
Users who make use of our accessibility features will expect dropdowns to be controllable via space-bar in addition to the enter key. We currently only support the latter. This pull request adds support for the former.
Focus areas to test
Manually verified on Dropdown.Basic.Example: