DatePicker: Restore focus after cycling out of the callout #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue 2 mentioned in #1266
5 tasks
MLoughry
requested changes
Apr 11, 2017
| if (ev.which === KeyCodes.enter) { | ||
| ev.preventDefault(); | ||
| this._onGotoToday(); | ||
| } else if (ev.which === KeyCodes.tab && !ev.shiftKey) { |
Contributor
There was a problem hiding this comment.
You should add similar logic for shift+tab on the first tab stop of the Calendar
MLoughry
approved these changes
Apr 11, 2017
Contributor
Author
|
Quick ping to @MLoughry to hit the merge button before the master advances again :) |
Member
|
@c-w do you not have merge access? We typically allow the PR creator to merge the PR once it has been approved. If not, I'll do it for you now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
After focus leaves the date picker, it skips everything else on the page, making it impossible to tab through the whole page. This pull request fixes this behavior by restoring focus to the date picker's text input after the picker is dismissed.
Focus areas to test
Test steps (verified manually on DatePicker.Input.Example: screencast):
(Split out from #1451)