ContextualMenu: Document onRender accessibility requirement#1560
Merged
micahgodbolt merged 1 commit intomicrosoft:masterfrom Apr 20, 2017
c-w:patch-1
Merged
ContextualMenu: Document onRender accessibility requirement#1560micahgodbolt merged 1 commit intomicrosoft:masterfrom c-w:patch-1
micahgodbolt merged 1 commit intomicrosoft:masterfrom
c-w:patch-1
Conversation
For keyboard accessibility, all custom-rendered context menus entries need to be focusable so that the FocusZone can set the appropriate tabIndex while navigating through the menu. Previously, this requirement was not documented which made it very easy to inadvertently create non-accessible context menus. For example, the "ContextualMenu customization example" on https://dev.office.com/fabric#/components/contextualmenu is currently not keyboard-accessible.
micahgodbolt
approved these changes
Apr 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
For keyboard accessibility, all custom-rendered context menus entries need to be focusable so that the FocusZone can set the appropriate tabIndex while navigating through the menu.
Previously, this requirement was not documented which made it very easy to inadvertently create non-accessible context menus. For example, the "ContextualMenu customization example" is currently not keyboard-accessible.
Hopefully this documentation update will make it easier for users to create accessible custom-rendered context menus.