-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Overflow): Update overflow menu when items are removed #31340
Merged
miroslavstastny
merged 2 commits into
microsoft:master
from
miroslavstastny:fix/overflow-menu-update
May 13, 2024
Merged
fix(Overflow): Update overflow menu when items are removed #31340
miroslavstastny
merged 2 commits into
microsoft:master
from
miroslavstastny:fix/overflow-menu-update
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 617 | 656 | 5000 | |
Button | mount | 297 | 304 | 5000 | |
Field | mount | 1153 | 1132 | 5000 | |
FluentProvider | mount | 708 | 702 | 5000 | |
FluentProviderWithTheme | mount | 82 | 78 | 10 | |
FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 71 | 73 | 10 | |
MakeStyles | mount | 862 | 874 | 50000 | |
Persona | mount | 1782 | 1722 | 5000 | |
SpinButton | mount | 1405 | 1395 | 5000 | |
SwatchPicker | mount | 1518 | 1552 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
george-cz
approved these changes
May 13, 2024
ling1726
approved these changes
May 13, 2024
miroslavstastny
changed the title
Fix/overflow menu update
fix(Overflow): Update overflow menu when items are removed
May 13, 2024
miroslavstastny
added a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
In
Overflow
, when anOverflowItem
was removed from the container, the overflow was updated only when the queue of visible items was changed by the removal.As a result, when an overflowing item was removed, the overflow menu was not updated. Similarly, when all overflow items were removed, the overflow menu was not removed.
New Behavior
Whenever
OverflowItem
is removed while theOverflow
is inobserving
state, force dispatch is triggered to update the overflow menu. This behavior matches the add logic.Related Issue(s)