Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-components): migrate from npmignore to package.json#files for release #31519

Merged
merged 3 commits into from
Jun 4, 2024
Merged

feat(web-components): migrate from npmignore to package.json#files for release #31519

merged 3 commits into from
Jun 4, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 30, 2024 •
edited
Loading

Previous Behavior

New Behavior

  • migrates from .npmignore to package.json#files in order to declare what will be shipped to npm
  • adds integration test via verify-packaging task target

Before

image

After

image

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 30, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented May 30, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@Hotell Hotell mentioned this pull request May 30, 2024
Closed
6 tasks
@Hotell Hotell marked this pull request as ready for review May 30, 2024 16:48
@Hotell Hotell requested review from a team as code owners May 30, 2024 16:48
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 30, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

radium-v
radium-v approved these changes May 30, 2024
View reviewed changes
packages/web-components/package.json Show resolved Hide resolved
packages/web-components/scripts/type-check.js Outdated Show resolved Hide resolved
@Hotell Hotell enabled auto-merge (squash) June 4, 2024 10:53
@tudorpopams tudorpopams self-requested a review June 4, 2024 12:10
@Hotell Hotell merged commit acfa5b4 into microsoft:master Jun 4, 2024
19 checks passed
@Hotell Hotell deleted the wc-3-followup/apply-files-for-release branch June 6, 2024 11:28
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
feat(web-components): migrate from npmignore to package.json#files fo…
a997ba0 
…r release (microsoft#31519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@radium-v radium-v radium-v approved these changes

@janechu janechu janechu approved these changes

@chrisdholt chrisdholt chrisdholt approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System web-components
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.
6 participants
@Hotell @fabricteam @radium-v @janechu @chrisdholt @tudorpopams