From aecd3eca15e41d3500d300b2d5c9484e74b5bba3 Mon Sep 17 00:00:00 2001 From: pelikhan Date: Thu, 13 Jun 2024 22:33:53 -0700 Subject: [PATCH] check status for cell --- packages/vscode/src/docsnotebook.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/vscode/src/docsnotebook.ts b/packages/vscode/src/docsnotebook.ts index 87f20d877..66acd44c7 100644 --- a/packages/vscode/src/docsnotebook.ts +++ b/packages/vscode/src/docsnotebook.ts @@ -186,6 +186,7 @@ function activateNotebookExecutor(state: ExtensionState) { schemas, trace, messages, + status, } = res const output = { text, @@ -240,7 +241,7 @@ function activateNotebookExecutor(state: ExtensionState) { ]), ].filter((o) => o) ) - execution.end(!error, Date.now()) + execution.end(status === "success", Date.now()) } catch (e) { await execution.replaceOutput([ new vscode.NotebookCellOutput([