diff --git a/commit-graph.c b/commit-graph.c index c91e6f0fb82158..ae210a3d6868fc 100644 --- a/commit-graph.c +++ b/commit-graph.c @@ -466,10 +466,6 @@ static int prepare_commit_graph(struct repository *r) struct object_directory *odb; int config_value; - if (git_env_bool(GIT_TEST_COMMIT_GRAPH_DIE_ON_LOAD, 0)) - die("dying as requested by the '%s' variable on commit-graph load!", - GIT_TEST_COMMIT_GRAPH_DIE_ON_LOAD); - if (r->objects->commit_graph_attempted) return !!r->objects->commit_graph; r->objects->commit_graph_attempted = 1; @@ -834,7 +830,7 @@ static void write_graph_chunk_data(struct hashfile *f, int hash_len, uint32_t packedDate[2]; display_progress(ctx->progress, ++ctx->progress_cnt); - parse_commit_no_graph(*list); + parse_commit(*list); hashwrite(f, get_commit_tree_oid(*list)->hash, hash_len); parent = (*list)->parents; @@ -1052,7 +1048,7 @@ static void close_reachable(struct write_commit_graph_context *ctx) if (!parse_commit(commit) && commit->graph_pos == COMMIT_NOT_FROM_GRAPH) add_missing_parents(ctx, commit); - } else if (!parse_commit_no_graph(commit)) + } else if (!parse_commit(commit)) add_missing_parents(ctx, commit); } stop_progress(&ctx->progress); @@ -1288,7 +1284,7 @@ static void copy_oids_to_commits(struct write_commit_graph_context *ctx) ctx->commits.list[ctx->commits.nr]->graph_pos != COMMIT_NOT_FROM_GRAPH) continue; - parse_commit_no_graph(ctx->commits.list[ctx->commits.nr]); + parse_commit(ctx->commits.list[ctx->commits.nr]); for (parent = ctx->commits.list[ctx->commits.nr]->parents; parent; parent = parent->next) diff --git a/commit-graph.h b/commit-graph.h index df9a3b20e4abc7..b1f2a2158ff69a 100644 --- a/commit-graph.h +++ b/commit-graph.h @@ -7,7 +7,6 @@ #include "cache.h" #define GIT_TEST_COMMIT_GRAPH "GIT_TEST_COMMIT_GRAPH" -#define GIT_TEST_COMMIT_GRAPH_DIE_ON_LOAD "GIT_TEST_COMMIT_GRAPH_DIE_ON_LOAD" struct commit; diff --git a/commit.h b/commit.h index 5d33477e788633..42728c2906608a 100644 --- a/commit.h +++ b/commit.h @@ -89,12 +89,6 @@ static inline int repo_parse_commit(struct repository *r, struct commit *item) { return repo_parse_commit_gently(r, item, 0); } - -static inline int parse_commit_no_graph(struct commit *commit) -{ - return repo_parse_commit_internal(the_repository, commit, 0, 0); -} - #ifndef NO_THE_REPOSITORY_COMPATIBILITY_MACROS #define parse_commit_internal(item, quiet, use) repo_parse_commit_internal(the_repository, item, quiet, use) #define parse_commit_gently(item, quiet) repo_parse_commit_gently(the_repository, item, quiet) diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh index 063f906b3eb0ed..3b0b1c386efe52 100755 --- a/t/t5318-commit-graph.sh +++ b/t/t5318-commit-graph.sh @@ -385,13 +385,7 @@ corrupt_graph_verify() { test_must_fail git commit-graph verify 2>test_err && grep -v "^+" test_err >err && test_i18ngrep "$grepstr" err && - if test "$2" != "no-copy" - then - cp $objdir/info/commit-graph commit-graph-pre-write-test - fi && - git status --short && - GIT_TEST_COMMIT_GRAPH_DIE_ON_LOAD=true git commit-graph write && - git commit-graph verify + git status --short } # usage: corrupt_graph_and_verify [] @@ -415,9 +409,10 @@ corrupt_graph_and_verify() { } test_expect_success POSIXPERM,SANITY 'detect permission problem' ' + test_when_finished chmod 666 $objdir/info/commit-graph && corrupt_graph_setup && chmod 000 $objdir/info/commit-graph && - corrupt_graph_verify "Could not open" "no-copy" + corrupt_graph_verify "Could not open" ' test_expect_success 'detect too small' ' @@ -536,7 +531,6 @@ test_expect_success 'git fsck (checks commit-graph)' ' git fsck && corrupt_graph_and_verify $GRAPH_BYTE_FOOTER "\00" \ "incorrect checksum" && - cp commit-graph-pre-write-test $objdir/info/commit-graph && test_must_fail git fsck '