Update CMake min req for gtest#171
Merged
Merged
Conversation
When the gtest version was bumped in dd3e782 the minimum required CMake version wasn't adjusted. This blocks CMake 4+ compatibility. * Change min required CMake version to match top level CMakeLists
SergioRZMasson
approved these changes
Jun 1, 2026
Corobi
added a commit
to Corobi/glTF-SDK
that referenced
this pull request
Jun 3, 2026
When the gtest version was bumped in dd3e782 the minimum required CMake version wasn't adjusted. This blocks CMake 4+ compatibility. * Change min required CMake version to match top level CMakeLists Co-authored-by: Sergio R. Z. Masson <97050577+SergioRZMasson@users.noreply.github.com> (cherry picked from commit 3bbc71c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change min required CMake version to match top level CMakeLists
When the gtest version was bumped in dd3e782 the minimum required CMake version wasn't adjusted which currently blocks CMake 4.0 compatibility since <3.10 backcompat was dropped in 4+.
This change bumps up the min cmake version requirement for the gtest dependency to match the requirement of the top level CMakeLists of the SDK.