Add EventHub connection info to deployment outputs#75
Merged
dustinburson merged 1 commit intomicrosoft:masterfrom Nov 18, 2020
c-w:output-eventhub-deployment-details
Merged
Add EventHub connection info to deployment outputs#75dustinburson merged 1 commit intomicrosoft:masterfrom c-w:output-eventhub-deployment-details
dustinburson merged 1 commit intomicrosoft:masterfrom
c-w:output-eventhub-deployment-details
Conversation
dustinburson
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the managed identity ARM template used to deploy the IoMT-connector to expose the names of the EventHubs used for ingestion as well as the hostname of the EventHub namespace that hosts those EventHubs. This change enables consumers of the template to set up RBAC roles and connect to the ingestion EventHubs without making assumptions about naming patterns used in the ARM template.
To facilitate the refactor, this pull request also pulls out the constants
normalizeddataanddevicedatainto template variables and updates the template to reference the variables instead of repeating the constants in multiple places. As such, if in the future the naming patters were to change, the strings can simply be updated in one location.cc @alexgolesh @wkilday