Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report build failure when the build errors are on the running project's classpath #459

Merged
merged 1 commit into from Nov 21, 2022

Conversation

testforstephen
Copy link
Contributor

  • For a build-tool managed project, will check if the running project and its references projects contain build errors. If so, report build failure. Otherwise, return succeed.
  • For unmanaged folder, only check if the running main class contains build errors. If so, report build failure. Otherwise, return succeed.

@jdneo
Copy link
Member

jdneo commented Nov 17, 2022

I'm thinking that how we can re-use the code in https://github.com/eclipse/eclipse.jdt.ls/blob/d4101ae14289ff7db98763cf731a0c74138589b8/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BuildWorkspaceHandler.java#L100

Now we build the entire workspace but only check the markers for the trigger project. That means we may waste some time for building unrelated projects.

@testforstephen
Copy link
Contributor Author

I'm thinking that how we can re-use the code in https://github.com/eclipse/eclipse.jdt.ls/blob/d4101ae14289ff7db98763cf731a0c74138589b8/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BuildWorkspaceHandler.java#L100

Now we build the entire workspace but only check the markers for the trigger project. That means we may waste some time for building unrelated projects.

I will hold on current behavior first before the performance becomes a concern.

@testforstephen testforstephen merged commit 4384d85 into microsoft:main Nov 21, 2022
@testforstephen testforstephen deleted the jinbo_build branch November 21, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants