Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dotnet] adds support for date-only, time-only and duration in Kiota #1041

Merged
merged 1 commit into from Jan 21, 2022
Merged

[Dotnet] adds support for date-only, time-only and duration in Kiota #1041

merged 1 commit into from Jan 21, 2022

Conversation

andrueastman
Copy link
Member

This PR is part of #1004

It covers dotnet changes needed to add support for date-only, time-only and duration in Kiota.

Changes involve

  • Adding the Date and Time types as the types from system are only available in dotnet 6.
  • Duration instances are represented with the TimeSpan type.
  • Adding relevant serialization methods to the abstractions and serialization packages.
  • Tests updated/added to cover the scenarios.

Sample generation of this using the full v1 description can be previewed here.

@andrueastman andrueastman self-assigned this Jan 20, 2022
@andrueastman andrueastman mentioned this pull request Jan 20, 2022
Merged
@andrueastman andrueastman added the CSharp Pull requests that update .net code label Jan 20, 2022
@andrueastman andrueastman added this to the Community Preview milestone Jan 20, 2022
baywet
baywet reviewed Jan 20, 2022
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for tackling this so quickly, just a few minor comments

src/Kiota.Builder/Writers/CSharp/CSharpConventionService.cs Outdated Show resolved Hide resolved
src/Kiota.Builder/Writers/CSharp/CodeMethodWriter.cs Outdated Show resolved Hide resolved
abstractions/dotnet/src/Time.cs Outdated Show resolved Hide resolved
@baywet baywet mentioned this pull request Jan 20, 2022
Merged
@andrueastman
Squash changes.
3048376 
-Date,Time and Duration type support for kiota in dotnet
@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@baywet baywet merged commit 9d25140 into bugfix/duration-date-time Jan 21, 2022
@baywet baywet deleted the andrueastman/dateTimeOnly branch January 21, 2022 13:33
This was referenced Jan 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@peombwa peombwa Awaiting requested review from peombwa

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@zengin zengin Awaiting requested review from zengin

Assignees

@andrueastman andrueastman

Labels
CSharp Pull requests that update .net code
Projects
None yet
Milestone
Community Preview
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrueastman @baywet