Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "non-empty string" comment for workspace/symbol #770

Closed
wants to merge 1 commit into from

Conversation

@DanTup
Copy link
Contributor

commented Jun 10, 2019

VS Code sends empty strings to LSP servers here to get a full symbol list. Based on discussion at microsoft/vscode-languageserver-node#458 I believe that the VS Code behaviour is desired and the spec is incorrect (the original intention was designed to avoid clients accidentally requesting all symbols before the user had typed, but it seems leaving that to the server is the best option).

VS Code sends empty strings to LSP servers here to get a full symbol list. Based on discussion at microsoft/vscode-languageserver-node#458 I believe that the VS Code behaviour is desired and the spec is incorrect (the original intention was designed to avoid clients accidentally requesting all symbols before the user had typed, but it seems leaving that to the server is the best option).
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

Merged into dbaeumer/3.15 branch

@dbaeumer dbaeumer closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.