Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #782 - InitializationParams.clientName #783

Closed
wants to merge 1 commit into from

Conversation

@mickaelistria
Copy link

commented Jul 1, 2019

This is already used by Eclipse LSP4J and related language servers and clients.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

Will merge into the new 3.15 release when I branch off.

@puremourning

This comment has been minimized.

Copy link

commented Jul 2, 2019

This new item it mandatory?! That’s a breaking change, right?

@mickaelistria

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

@puremourning you're right, I'll make it optional.

This is already used by Eclipse LSP4J and related language servers and clients.
@mickaelistria mickaelistria force-pushed the mickaelistria:patch-5 branch from e36ad23 to c2ccaf4 Jul 2, 2019
@mickaelistria

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

@puremourning you're right, I'll make it optional.

Done, thanks for the review!

@puremourning

This comment has been minimized.

Copy link

commented Jul 3, 2019

You’re wecome! Thanks for sorting it :)

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Add to 3.15 branch with the following modification:

  • name & version
  • for client and server

The branch is https://github.com/microsoft/language-server-protocol/tree/dbaeumer/3.15

@dbaeumer dbaeumer closed this Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.