Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SignatureHelpContext #805

Closed

Conversation

@KamasamaK
Copy link
Contributor

commented Jul 27, 2019

This adds SignatureHelpContext to the textDocument/signatureHelp request.

Fixes #561

Fixes #797

@KamasamaK

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Note that I changed SignatureHelpTriggerKind.Invoke from VS Code to Invoked so it is consistent with CompletionTriggerKind, which was also changed from VS Code.

Also, sorry I included some unrelated syntax fixes that I noticed while doing this.

@dbaeumer dbaeumer added this to the 3.15 milestone Aug 12, 2019
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@dbaeumer dbaeumer closed this Sep 9, 2019
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Add implementation to client as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.