Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory #804

Merged
merged 7 commits into from
Sep 6, 2019
Merged

Inventory #804

merged 7 commits into from
Sep 6, 2019

Conversation

AndKram
Copy link
Collaborator

@AndKram AndKram commented Mar 25, 2019

From #797. Added missing mission.xml changes. Adjusted the default amount(s) attributes in MissionHandlers.xsd. Currently failing PythonIntegrationTests_inventory_test.

@AndKram
Copy link
Collaborator Author

AndKram commented Mar 25, 2019

I think the reward needs updating with something like:
int dimension = params.getDimension();
float adjusted_reward = this.adjustAndDistributeReward(
((BlockOrItemSpecWithReward) matcher.matchSpec).getReward().floatValue(),
params.getDimension(),
((BlockOrItemSpecWithReward) matcher.matchSpec).getDistribution());
addCachedReward(dimension, adjusted_reward);

in all the RewardFor*.getMatch() methods.

But the test assumes that the reward is given each time the number of items are collected.

@AndKram
Copy link
Collaborator Author

AndKram commented May 13, 2019

Now restored backwards compatibility. Need more testing of new functionality.

@AndKram AndKram merged commit 26433ad into master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant