From cd33e34330614c0bf26d412efea246ce199f084e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 16:19:04 +0000 Subject: [PATCH 1/5] Initial plan From 55f85678b38945b3e2f307fce7e8b88806614fbc Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 16:23:17 +0000 Subject: [PATCH 2/5] Remove App Lens web site kind restriction Agent-Logs-Url: https://github.com/microsoft/mcp/sessions/274dcc6a-c7ea-4e2d-a43e-6ed2c6e2f60f Co-authored-by: tmeschter <10506730+tmeschter@users.noreply.github.com> --- .../Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs | 7 +++---- .../Resource/ResourceDiagnoseCommandTests.cs | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs index d3657b9c76..f1c10cbd2e 100644 --- a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs +++ b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs @@ -255,15 +255,14 @@ private async Task> ExecuteArgQueryAsync( } /// - /// Checks whether a resource type (and optionally kind) is supported by AppLens diagnostics. + /// Checks whether a resource type is supported by AppLens diagnostics. /// internal static bool IsResourceTypeSupported(string resourceType, string resourceKind) { if (resourceType.Equals("microsoft.web/sites", StringComparison.OrdinalIgnoreCase)) { - return resourceKind.Equals("app", StringComparison.OrdinalIgnoreCase) - || resourceKind.Equals("linux", StringComparison.OrdinalIgnoreCase) - || resourceKind.Equals("functionapp", StringComparison.OrdinalIgnoreCase); + _ = resourceKind; + return true; } return resourceType.Equals("microsoft.containerservice/managedclusters", StringComparison.OrdinalIgnoreCase) diff --git a/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs b/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs index 647764854b..7343d4f61f 100644 --- a/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs +++ b/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs @@ -417,14 +417,14 @@ await ExecuteCommandAsync( [InlineData("microsoft.web/sites", "app", true)] [InlineData("microsoft.web/sites", "linux", true)] [InlineData("microsoft.web/sites", "functionapp", true)] + [InlineData("microsoft.web/sites", "container", true)] + [InlineData("microsoft.web/sites", "", true)] [InlineData("Microsoft.Web/Sites", "App", true)] [InlineData("MICROSOFT.WEB/SITES", "APP", true)] [InlineData("microsoft.containerservice/managedclusters", "", true)] [InlineData("Microsoft.ContainerService/managedClusters", "", true)] [InlineData("microsoft.apimanagement/service", "", true)] [InlineData("Microsoft.ApiManagement/service", "", true)] - [InlineData("microsoft.web/sites", "container", false)] - [InlineData("microsoft.web/sites", "", false)] [InlineData("microsoft.compute/virtualmachines", "", false)] [InlineData("microsoft.storage/storageaccounts", "", false)] [InlineData("microsoft.sql/servers", "", false)] From 89033f4aa4631c3d33f3e81a7cbb2dc61f07d2e7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 16:24:21 +0000 Subject: [PATCH 3/5] Remove unnecessary discard in AppLens support check Agent-Logs-Url: https://github.com/microsoft/mcp/sessions/274dcc6a-c7ea-4e2d-a43e-6ed2c6e2f60f Co-authored-by: tmeschter <10506730+tmeschter@users.noreply.github.com> --- tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs index f1c10cbd2e..6076e2cc95 100644 --- a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs +++ b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs @@ -261,7 +261,6 @@ internal static bool IsResourceTypeSupported(string resourceType, string resourc { if (resourceType.Equals("microsoft.web/sites", StringComparison.OrdinalIgnoreCase)) { - _ = resourceKind; return true; } From c66628d8a3df077e5fc8e985db58f9adf016bbde Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 16:25:42 +0000 Subject: [PATCH 4/5] Simplify AppLens resource support check signature Agent-Logs-Url: https://github.com/microsoft/mcp/sessions/274dcc6a-c7ea-4e2d-a43e-6ed2c6e2f60f Co-authored-by: tmeschter <10506730+tmeschter@users.noreply.github.com> --- .../src/Services/AppLensService.cs | 4 +-- .../Resource/ResourceDiagnoseCommandTests.cs | 28 ++++++++----------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs index 6076e2cc95..061810bcf3 100644 --- a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs +++ b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs @@ -147,7 +147,7 @@ internal async Task FindResourceAsync( // Filter to supported resource types var supportedResults = filteredResults - .Where(r => IsResourceTypeSupported(r.ResourceType, r.ResourceKind)) + .Where(r => IsResourceTypeSupported(r.ResourceType)) .ToImmutableArray(); if (supportedResults.Length == 0) @@ -257,7 +257,7 @@ private async Task> ExecuteArgQueryAsync( /// /// Checks whether a resource type is supported by AppLens diagnostics. /// - internal static bool IsResourceTypeSupported(string resourceType, string resourceKind) + internal static bool IsResourceTypeSupported(string resourceType) { if (resourceType.Equals("microsoft.web/sites", StringComparison.OrdinalIgnoreCase)) { diff --git a/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs b/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs index 7343d4f61f..fb77213236 100644 --- a/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs +++ b/tools/Azure.Mcp.Tools.AppLens/tests/Azure.Mcp.Tools.AppLens.UnitTests/Resource/ResourceDiagnoseCommandTests.cs @@ -414,24 +414,20 @@ await ExecuteCommandAsync( } [Theory] - [InlineData("microsoft.web/sites", "app", true)] - [InlineData("microsoft.web/sites", "linux", true)] - [InlineData("microsoft.web/sites", "functionapp", true)] - [InlineData("microsoft.web/sites", "container", true)] - [InlineData("microsoft.web/sites", "", true)] - [InlineData("Microsoft.Web/Sites", "App", true)] - [InlineData("MICROSOFT.WEB/SITES", "APP", true)] - [InlineData("microsoft.containerservice/managedclusters", "", true)] - [InlineData("Microsoft.ContainerService/managedClusters", "", true)] - [InlineData("microsoft.apimanagement/service", "", true)] - [InlineData("Microsoft.ApiManagement/service", "", true)] - [InlineData("microsoft.compute/virtualmachines", "", false)] - [InlineData("microsoft.storage/storageaccounts", "", false)] - [InlineData("microsoft.sql/servers", "", false)] - public void IsResourceTypeSupported_ReturnsCorrectResult(string resourceType, string resourceKind, bool expected) + [InlineData("microsoft.web/sites", true)] + [InlineData("Microsoft.Web/Sites", true)] + [InlineData("MICROSOFT.WEB/SITES", true)] + [InlineData("microsoft.containerservice/managedclusters", true)] + [InlineData("Microsoft.ContainerService/managedClusters", true)] + [InlineData("microsoft.apimanagement/service", true)] + [InlineData("Microsoft.ApiManagement/service", true)] + [InlineData("microsoft.compute/virtualmachines", false)] + [InlineData("microsoft.storage/storageaccounts", false)] + [InlineData("microsoft.sql/servers", false)] + public void IsResourceTypeSupported_ReturnsCorrectResult(string resourceType, bool expected) { // Act - var result = AppLensService.IsResourceTypeSupported(resourceType, resourceKind); + var result = AppLensService.IsResourceTypeSupported(resourceType); // Assert Assert.Equal(expected, result); From c58f4b30b2cdcdb847dfc39cacae8ecc6aced0d6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 6 May 2026 16:59:18 +0000 Subject: [PATCH 5/5] Simplify AppLens supported type check using shared list Agent-Logs-Url: https://github.com/microsoft/mcp/sessions/06514e5e-b94e-43ef-8657-e8896f88653a Co-authored-by: tmeschter <10506730+tmeschter@users.noreply.github.com> --- .../src/Services/AppLensService.cs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs index 061810bcf3..a6e1b580f7 100644 --- a/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs +++ b/tools/Azure.Mcp.Tools.AppLens/src/Services/AppLensService.cs @@ -259,13 +259,7 @@ private async Task> ExecuteArgQueryAsync( /// internal static bool IsResourceTypeSupported(string resourceType) { - if (resourceType.Equals("microsoft.web/sites", StringComparison.OrdinalIgnoreCase)) - { - return true; - } - - return resourceType.Equals("microsoft.containerservice/managedclusters", StringComparison.OrdinalIgnoreCase) - || resourceType.Equals("microsoft.apimanagement/service", StringComparison.OrdinalIgnoreCase); + return SupportedResourceTypes().Contains(resourceType, StringComparer.OrdinalIgnoreCase); } ///