Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set march=native on Apple Silicon #344

merged 2 commits into from Dec 17, 2020


Copy link

@xhochy xhochy commented Dec 15, 2020

Fixes #340

There is the alternative between not stetting anything and using march=armv8. From my understanding, they produce exactly the same results for now.

Copy link

devnexen commented Dec 15, 2020

Seems accurate or maybe using the check_cxx_compiler_flag directive as alternative might fit too.

Copy link
Contributor Author

xhochy commented Dec 15, 2020

From the packager perspective (I package a lot for conda-forge), I really get annoyed when some upstream library puts march=native per default and without a switch in their code. Thus I would avoid setting it unnecessarily as this pins packages to the machine I build them on and make them thus not-redistributable.

For writing a better patch, I would need a Linux-aarch64 setup which I currently don't have access to.

Copy link

Good points, the check_cxx_compiler_flag has just the merit to discard every case we might not have thinkg of when not supported.

@daanx daanx merged commit b650aa9 into microsoft:dev Dec 17, 2020
1 check passed
Copy link

daanx commented Dec 17, 2020

Thanks so much! Hope we can make the M1 work :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants