Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Test pipeline for Monaco Editor #1668

Closed
rebornix opened this issue Nov 8, 2019 · 3 comments
Closed

Build/Test pipeline for Monaco Editor #1668

rebornix opened this issue Nov 8, 2019 · 3 comments
Assignees

Comments

@rebornix
Copy link
Member

@rebornix rebornix commented Nov 8, 2019

Right now we majorly rely on maintainers to do testing and sanity checks before every release manually. Considering that we now support both AMD and ESM and we have 5 built in extensions shipped with Monaco Editor, an automatic build and test pipeline can help us avoid shipping broken bits as much as possible.

  • Fetch master from VS Code and build Monaco Editor core from it
    • Throw when build and tree shaking fails
  • Test the core and ensure the basic functionalities work

CI configuration is defined in https://github.com/microsoft/monaco-editor/blob/master/.github/workflows/ci.yml

@rebornix rebornix self-assigned this Nov 8, 2019
@kieferrm kieferrm mentioned this issue Nov 11, 2019
50 of 68 tasks complete
@orta

This comment has been minimized.

Copy link
Member

@orta orta commented Nov 12, 2019

I don't think it'll be too useful for you, but you might be able to take some of my work form https://github.com/orta/make-monaco-builds

@rebornix

This comment has been minimized.

Copy link
Member Author

@rebornix rebornix commented Nov 12, 2019

@orta thanks, I like the nightly build setup, only one question, it will publish monaco-editor nightly with monaco-editor-core from NPM and TypeScript nightly, right? In my setup, it's the other way around: we bundle monaco-editor-core from vscode master and monaco-typescript from NPM, run tests against it to see if there are any potential bugs.

@rebornix

This comment has been minimized.

Copy link
Member Author

@rebornix rebornix commented Dec 6, 2019

Shipped.

@rebornix rebornix closed this Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.