Skip to content

FIX: PR formatting check incorrectly passes for templates with unclosed HTML comments #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

FIX: PR formatting check incorrectly passes for templates with unclosed HTML comments #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aabe32
Initial plan
Copilot Sep 4, 2025
fad53aa
Fix PR formatting check to handle unclosed HTML comments
Copilot Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pr-format-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ jobs:
// Extract the summary content
const summaryContent = summaryMatch[1];

// Remove all HTML comments including the template placeholder
// Remove all HTML comments including unclosed ones (template placeholders)
const contentWithoutComments =
summaryContent.replace(/<!--[\s\S]*?-->/g, '');
summaryContent.replace(/<!--[\s\S]*?(?:-->|$)/g, '');

// Remove whitespace and check if there's actual text content
const trimmedContent = contentWithoutComments.trim();
Expand Down
Loading