FEAT: Implementation of C++ Connection Class API #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new ODBC Connection class and underlying support for dynamic driver loading and handle management in the mssql_python project.
- Implements the
Connectionclass for connect/disconnect, transactions, autocommit, and statement allocation - Adds ODBC API function-pointer typedefs, a
DriverLoadersingleton, and an RAIISqlHandlewrapper - Centralizes driver loading and pointer resolution in
ddbc_bindings.h
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mssql_python/pybind/ddbc_bindings.h | Added ODBC API typedefs, logging/exception helpers, DriverLoader, SqlHandle |
| mssql_python/pybind/connection/connection.h | Declared the Connection class and its public interface |
| mssql_python/pybind/connection/connection.cpp | Implemented Connection methods (connect/close, transactions, autocommit) |
Comments suppressed due to low confidence (1)
mssql_python/pybind/ddbc_bindings.h:4
- [nitpick] Fix the grammar in this comment: replace "that is file" with "this file".
// INFO|TODO - Note that is file is Windows specific right now. Making it arch agnostic will be
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
2 times, most recently
from
05231ba to
cd20ea2
Compare
gargsaumya
force-pushed
the
saumya/connectionclassc++
branch
from
7727ace to
eb7161e
Compare
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
from
cd20ea2 to
37f6dcb
Compare
gargsaumya
changed the title
gargsaumya
force-pushed
the
saumya/connectionclassc++
branch
from
daf84f8 to
eca18a0
Compare
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
3 times, most recently
from
56cf353 to
c89cfbe
Compare
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
from
f979de7 to
896f34d
Compare
sumitmsft
reviewed
May 26, 2025
sumitmsft
reviewed
May 26, 2025
sumitmsft
reviewed
May 26, 2025
sumitmsft
reviewed
May 26, 2025
sumitmsft
reviewed
May 26, 2025
bewithgaurav
requested changes
May 27, 2025
1 task
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
2 times, most recently
from
5ecc8fd to
6a077c6
Compare
gargsaumya
force-pushed
the
saumya/conn_implementation
branch
from
6a077c6 to
c8dfd0e
Compare
bewithgaurav
previously approved these changes
May 29, 2025
sumitmsft
previously approved these changes
May 29, 2025
Contributor
sumitmsft
left a comment
sumitmsft
left a comment
There was a problem hiding this comment.
All comments have been resolved. Relevant changes made.
* refactor native layer and create reusable components * add newline * Delete copy/assign for DriverLoader singleton * resolve review comments * initial edit * working flow with c++ connection class * working interation with access token * cleanup free() in sqlhandle * removed unnecessary prints * removing comment * resolving conflict * working * final working-fix test * minor updates * updating file * added a TODO comment to address review comments --------- Co-authored-by: Saumya Garg <gargsaumya@microsoft.com>
sumitmsft
approved these changes
May 29, 2025
bewithgaurav
approved these changes
May 29, 2025
Collaborator
bewithgaurav
left a comment
bewithgaurav
left a comment
There was a problem hiding this comment.
Create a task for the memory issue https://sqlclientdrivers.visualstudio.com/mssql-python/_workitems/edit/37606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Task ID [AB#37539]
This pull request introduces a new
Connectionclass and supporting infrastructure for managing ODBC database connections in themssql_pythonproject. Key changes include the implementation of theConnectionclass, the addition of function pointer typedefs for ODBC APIs, and the creation of utility classes for driver management and handle lifecycle management.New
ConnectionClass Implementation:mssql_python/pybind/connection/connection.cpp: Implements theConnectionclass, which provides methods for connecting to a database, managing transactions, and configuring autocommit. It uses RAII for resource management viaSqlHandle.mssql_python/pybind/connection/connection.h: Declares theConnectionclass, including methods for connection management, transaction handling, and autocommit configuration.ODBC Function Pointer Typedefs and Utilities:
mssql_python/pybind/ddbc_bindings.h: Adds typedefs for ODBC API function pointers, logging utilities, and exception helpers. Introduces theDriverLoadersingleton for centralized driver loading and theSqlHandleclass for RAII-based handle management.Checklist