FIX: minor cleanup, adding LOG statement instead of print #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logging mechanism in the ConnectionPool::acquire method by replacing std::cout with the LOG function for more consistent error reporting.
- Replaces std::cout with LOG for error logging when disconnecting bad/expired connections.
- Adjusts the error message to better reflect the context of a connection failure.
Comments suppressed due to low confidence (1)
mssql_python/pybind/connection/connection_pool.cpp:69
- [nitpick] Consider aligning the error message with the previous version by explicitly indicating 'disconnect() failed' or including the method name if it aids in faster debugging.
LOG("Disconnect bad/expired connections failed: ", ex.what());
sumitmsft
approved these changes
Jun 2, 2025
bewithgaurav
approved these changes
Jun 2, 2025
Collaborator
bewithgaurav
left a comment
bewithgaurav
left a comment
There was a problem hiding this comment.
lgtm, please rename the PR to start from FIX:
gargsaumya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging mechanism in the
ConnectionPool::acquiremethod to improve error reporting when disconnecting bad or expired connections.mssql_python/pybind/connection/connection_pool.cpp: Replacedstd::coutlogging with aLOGfunction for better consistency and integration with the logging system.