Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove windbg breakpoint workaround & improvements #25

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove windbg breakpoint workaround & improvements #25

merged 1 commit into from
May 6, 2024

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented May 6, 2024

Description

  1. Remove workaround where windbgx wasn't able to step when broken on debug breakpoints for [Bug]: Step does not work on initial breakpoint of module load breakpoint in windbg #10. This is fixed in windbgx version 1.2405.3001.0
  2. Minor improvements to the info monitor command.
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested locally with Q35

Integration Instructions

N/A

@cfernald cfernald requested review from kuqin12 and apop5 May 6, 2024 16:21
@apop5
Copy link
Contributor

apop5 commented May 6, 2024

it looks like PcdEnableWindbgWorkarounds is no longer consumed by any modules.

Could this token be removed from dec and inf files?

@cfernald
Copy link
Contributor Author

cfernald commented May 6, 2024 •
edited
Loading

PcdEnableWindbgWorkarounds

@apop5 It's still used in GdbStub.c@421

@cfernald cfernald merged commit 6f04dea into microsoft:main May 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuqin12 kuqin12 kuqin12 approved these changes

@apop5 apop5 apop5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfernald @apop5 @kuqin12