Skip to content

Op slicing upstream refactor#14832

Merged
pengwa merged 4 commits into
mainfrom
pengwa/refactor_compute_opt
Mar 13, 2023
Merged

Op slicing upstream refactor#14832
pengwa merged 4 commits into
mainfrom
pengwa/refactor_compute_opt

Conversation

@pengwa
Copy link
Copy Markdown
Contributor

@pengwa pengwa commented Feb 26, 2023

Slice op upstream refactor

A refactor work for #13672.

Motivation and Context

There is a similar optimization opportunity for other operator upstreaming, to reduce compute flops. So refactor the existing code base for making it easier to support other ops.

The changes in this PR are mainly about renaming and moving.

  • Move common logic (from compute_optimizer.h/cc) into upstream_transformer_base.h/cc and shared_utils.h/cc.
    • For upstream common logic, they are moved into upstream_transformer_base.h/cc
    • For shared utilities, they are moved to shared_utils.h/cc.
  • After the move, compute_optimizer.h/cc mainly for upstreaming gather implementation (inheriting upstream_transformer_base.h/cc). Ideally it should be renamed, but for easier review this time, I keep its name.

@pengwa pengwa added the training issues related to ONNX Runtime training; typically submitted using template label Feb 26, 2023
@pengwa pengwa changed the title Slice op upstream refactor Op slicing upstream refactor Feb 26, 2023
@pengwa pengwa requested a review from guyang3532 March 2, 2023 13:20
@pengwa pengwa force-pushed the pengwa/refactor_compute_opt branch from a1a4e65 to 3a72d77 Compare March 3, 2023 12:45
Copy link
Copy Markdown
Contributor

@askhade askhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengwa pengwa merged commit 448e989 into main Mar 13, 2023
@pengwa pengwa deleted the pengwa/refactor_compute_opt branch March 13, 2023 00:19
@pengwa pengwa mentioned this pull request Mar 13, 2023
pengwa added a commit that referenced this pull request Mar 13, 2023
### Renaming files for compute optimizer

### Motivation and Context

A follow up for #14832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants