Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter] Create a pass to turn tensors into external tensors #1696

Closed
Tracked by #129274
justinchuby opened this issue Jun 22, 2024 · 2 comments · Fixed by #1796
Closed
Tracked by #129274

[exporter] Create a pass to turn tensors into external tensors #1696

justinchuby opened this issue Jun 22, 2024 · 2 comments · Fixed by #1796
Assignees
@shubhambhokare1
Labels
contribution welcome We welcome code contributions for this topic: IR Intermediate representation

Comments

@justinchuby
Copy link
Collaborator

Create a pass to turn all tensors into external tensors in the IR. This can be seen as a pass with side effects. Needed to support efficient serialization in the exporter.
@justinchuby justinchuby added the topic: IR Intermediate representation label Jun 22, 2024
@justinchuby justinchuby mentioned this issue Jun 22, 2024
Open
16 tasks
@justinchuby justinchuby added the contribution welcome We welcome code contributions for this label Jun 22, 2024
@justinchuby justinchuby changed the title [IR] Create a pass to turn tensors into external tensors [exporter] Create a pass to turn tensors into external tensors Jun 22, 2024
@justinchuby
Copy link
Collaborator Author

justinchuby commented Jul 22, 2024 •
edited

Tensors need to align at 64kb: onnx/onnx#6247, onnx/onnx#6248

@justinchuby
Copy link
Collaborator Author

Basically implementing https://onnx.ai/onnx/api/external_data_helper.html#convert-model-to-external-data

@justinchuby justinchuby mentioned this issue Aug 5, 2024
Open
21 tasks
@justinchuby justinchuby mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhambhokare1 shubhambhokare1

Labels
contribution welcome We welcome code contributions for this topic: IR Intermediate representation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[IR] Pass to offload external tensors microsoft/onnxscript
2 participants
@justinchuby @shubhambhokare1