From 0a0e7b570e3b626a37c5c0415dd52b9312b41464 Mon Sep 17 00:00:00 2001 From: Justin Chu Date: Mon, 7 Aug 2023 21:08:56 +0000 Subject: [PATCH 1/2] [Do not merge] Debug min/max with ORT --- .github/workflows/main.yaml | 2 +- onnxscript/tests/function_libs/torch_lib/ops_test_common.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index e67e9254d3..1a0a577573 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -60,7 +60,7 @@ jobs: - name: Install nox run: python -m pip install nox - name: Run tests - run: nox -t ${{ matrix.nox-tag }} --forcecolor -- -v --cov=onnxscript --cov-report=xml --cov-append --cov-branch -n=auto --junit-xml pytest.xml + run: nox -t ${{ matrix.nox-tag }} --forcecolor -- --cov=onnxscript --cov-report=xml --cov-append --cov-branch -n=auto --junit-xml pytest.xml -s env: CATCH_ORT_SEGFAULT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}" CREATE_REPRODUCTION_REPORT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}" diff --git a/onnxscript/tests/function_libs/torch_lib/ops_test_common.py b/onnxscript/tests/function_libs/torch_lib/ops_test_common.py index 7a2e5b4040..653ae86347 100644 --- a/onnxscript/tests/function_libs/torch_lib/ops_test_common.py +++ b/onnxscript/tests/function_libs/torch_lib/ops_test_common.py @@ -524,6 +524,9 @@ def _capture_graph_and_evaluate_torch_script_evaluator(function: Callable, args, f"ONNX model is invalid. Model:\n{onnxscript.proto2text(onnx_model)}" ) from e + if ("min" in test_name or "max" in test_name) and "pool" not in test_name: + print(test_name, "ort_inputs", ort_inputs) + try: if ( os.environ.get("CATCH_ORT_SEGFAULT") == "1" From fc56c1e07b31ccf68aee35de6597b9dcf84462c1 Mon Sep 17 00:00:00 2001 From: Justin Chu Date: Mon, 7 Aug 2023 15:54:31 -0700 Subject: [PATCH 2/2] Remove parallel --- .github/workflows/main.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml index 1a0a577573..62543f8016 100644 --- a/.github/workflows/main.yaml +++ b/.github/workflows/main.yaml @@ -60,7 +60,7 @@ jobs: - name: Install nox run: python -m pip install nox - name: Run tests - run: nox -t ${{ matrix.nox-tag }} --forcecolor -- --cov=onnxscript --cov-report=xml --cov-append --cov-branch -n=auto --junit-xml pytest.xml -s + run: nox -t ${{ matrix.nox-tag }} --forcecolor -- --cov=onnxscript --cov-report=xml --cov-append --cov-branch --junit-xml pytest.xml -s env: CATCH_ORT_SEGFAULT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}" CREATE_REPRODUCTION_REPORT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}"