This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Fix dependency properties for Azure Monitor Trace Exporter #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Nov 23, 2019
| baseData=data, baseType="RemoteDependencyData" | ||
| ) | ||
| if span.kind in (SpanKind.CLIENT, SpanKind.PRODUCER): | ||
| data.type = "HTTP" # TODO |
There was a problem hiding this comment.
oh, would you mind fixing this one too in this PR? Or should I create another issue similar to census-instrumentation/opencensus-python#825?
Contributor
Author
There was a problem hiding this comment.
I will fix this here! :)
lmolkova
reviewed
Nov 23, 2019
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
left a comment about dependency type HTTP for all client spans
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses [#14]
data.datais url.
data.target is host:port
data.name is METHOD/path