Remove log noise for openai/langchain, add lazy load for langchain and fix Activity return type#98
Merged
Conversation
…d fix Activity return type
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce GenAI instrumentation log noise (OpenAI Agents / LangChain), make LangChain tracer loading lazy to avoid optional dependency issues, and align hosting ActivityLike typing for getAgenticInstanceId.
Changes:
- Downgrade “optional dependency missing” initialization/reset logs for OpenAI Agents and LangChain instrumentations from
warntodebug. - Lazy-load the LangChain tracer implementation to avoid eager runtime imports of
@langchain/coretransitive deps. - Update
ActivityLike.getAgenticInstanceIdto allowundefined, and adjust related unit tests.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/genai/instrumentations/langchain/langchainTraceInstrumentor.ts |
Switches LangChain tracer import to lazy loading and updates handler injection to accept a tracer constructor. |
src/distro/distro.ts |
Reduces log severity/noise when optional GenAI packages aren’t installed; adds explanatory comments. |
src/a365/hosting/types.ts |
Updates ActivityLike.getAgenticInstanceId return type to string | undefined. |
test/internal/unit/genai/langchain/langchainTraceInstrumentor.test.ts |
Updates tests for the new addTracerToHandlers signature. |
test/internal/unit/a365/hosting/outputLoggingMiddleware.test.ts |
Adjusts type narrowing in test setup for the updated ActivityLike signature. |
test/internal/unit/a365/hosting/baggageMiddleware.test.ts |
Adjusts type narrowing in test setup for the updated ActivityLike signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremydvoss
approved these changes
May 1, 2026
JacksonWeber
approved these changes
May 1, 2026
JacksonWeber
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.