CI: Give vmm tests more threads and more time #2145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Increase reliability of VMM tests in CI by allocating more execution resources, extending watchdog timeouts, and ensuring specific long-running tests are categorized as heavy.
- Renames two large memory validation tests to include "heavy" so they match nextest filter logic.
- Increases internal VM watchdog timeout (7m -> 10m) and nextest slow-timeout (10m -> 15m).
- Raises threads-required thresholds for general, OpenHCL, and heavy test classes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch.rs | Renames two test functions from *_large to *_heavy to opt them into the heavy test profile. |
| petri/src/vm/mod.rs | Extends per-VM watchdog timeout constant from 7 to 10 minutes. |
| .config/nextest.toml | Increases threads-required values and extends slow-timeout; adjusts comments accordingly (one now inconsistent). |
mattkur
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're still seeing occasional PR failures due to timeouts where the test content is just running very slowly. Mark vmm tests as needing more threads in nextest to try to reduce any possible core contention, give these tests a bunch more time, and mark two new tests with the correct magic word to have nextest account for them.