virt_whp: Reset more state during scrub and reset#3539
Open
smalis-msft wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WHP backend’s VTL2 scrub path to clear per-virtual-processor “VTL2 enabled” state for non-BSP VPs, preventing APs from resuming with stale pre-scrub register context when new VTL2 firmware reinitializes them.
Changes:
- Clear
vtl2_enableon all non-BSP VPs duringWhpPartition::scrub(Vtl2). - Add detailed rationale in-code describing why APs must be re-enabled via
HvCallEnableVpVtlafter scrub.
jstarks
reviewed
May 20, 2026
jstarks
reviewed
May 20, 2026
auto-merge was automatically disabled
May 21, 2026 20:34
Pull request was converted to draft
smalis-msft
changed the title
smalis-msft
changed the title
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
jstarks
reviewed
May 22, 2026
jstarks
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear way more WHP state during the scrub and reset processes to prevent stale register values and potential faults upon resuming. Also fix a case where we were returning the wrong error code in virt_mshv_vtl, found during the same audits.
Hopefully fixes #71.