This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
clean ${PAI_WORK_DIR} before mv content to this folder #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prod env, we saw when node down and up. The pod running on this node
may be restarted by kubelet. Even though the `restartPolicy` set to
`Never`. If that happens, the init container script will failed when
executing `mv` command. To prevent this, we clean the `${PAI_WORK_DIR}`
before mv content to this folder.
|
We should make our runtime Idempotent, since k8s restartPolicy=Never seems to be at least once execution like FC. So please confirm it and refine other places in runtime code. Seems at least for below code, after create container, kubelet does not record the container id for recovery, so if kubelet is killed just after StartContainer, kubelet will create another container even if restartPolicy=Never, because kubelet does not know it has already created before. |
abuccts
reviewed
Oct 9, 2019
src/kube-runtime/src/init
Outdated
| @@ -78,6 +79,10 @@ PAI_RUNTIME_DIR=${PAI_WORK_DIR}/runtime.d | |||
|
|
|||
| PAI_LOG_DIR=${PAI_WORK_DIR}/logs/${FC_POD_UID} | |||
|
|
|||
| # Clean ${PAI_WORK_DIR} and ${PAI_LOG_DIR} since they may contain last execution content. (rarely happen, but seen in real world) | |||
| rm -rf ${PAI_WORK_DIR}/* | |||
| rm -rf ${PAI_LOG_DIR}/* | |||
There was a problem hiding this comment.
do you need to clean log dir? keep the previous log may be helpful #Resolved
There was a problem hiding this comment.
yqwang-ms
reviewed
Oct 9, 2019
yqwang-ms
reviewed
Oct 9, 2019
yqwang-ms
reviewed
Oct 9, 2019
yqwang-ms
reviewed
Oct 10, 2019
yqwang-ms
reviewed
Oct 10, 2019
| # Move previous logs to another folder. Notice: for init.log, some part will append to previous log file | ||
| LOG_FILES=$(find $PAI_LOG_DIR -maxdepth 1 -type f) | ||
| if [[ ! -z $LOG_FILES ]]; then | ||
| RANDOM=$$ |
There was a problem hiding this comment.
Can we print warning log here?
Binyang2014
force-pushed
the
binyli/mv_failed
branch
from
0931eac
to
f162631
Compare
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prod env, we saw when node down and up. The pod running on this node
may be restarted by kubelet. Even though the
restartPolicyset toNever. If that happens, the init container script will failed whenexecuting
mvcommand. To prevent this, we clean the${PAI_WORK_DIR}before mv content to this folder.