-
Notifications
You must be signed in to change notification settings - Fork 31
Use exception logging to capture failures in app insights #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use exception logging to capture failures in app insights #14
Conversation
|
@lossyrob does the sku in |
|
@jisantuc it was a compatibility issue - the former dev environment used the old SKU so it was a var to avoid the update changing the existing instance. We can change remove the var as the new dev stack uses the newer sku, and there's no deployments that use the older sku |
|
I wound up bailing on the liveness path detection efforts. For whatever reason, despite the liveness path configuration appearing to be correct in the deployed service, I was unable to get rid of traces for those requests. However, traces for HEAD requests are still removed, which eliminates a significant source of application insights noise. |
Description
This PR adds a middleware to send any non-
HTTPExceptions to application insights.HTTPExceptionsare excluded because they're raised for things like 404s, bad auth, etc. (https://fastapi.tiangolo.com/tutorial/handling-errors/), or what you might call normal request failures.Type of change
How Has This Been Tested?
I raised an error as part of the middleware and was able to see the exception in app insights by providing the staging app insights instrumentation key. I've provided that screenshot in the Azure DevOps task I'm working on.
Checklist: