From 9918260925396fa59c4bb4cdfeb7eb48c5240ac0 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 11 Nov 2022 18:29:51 -0800 Subject: [PATCH] fix: do not fail on a bad file name in stack trace --- .../microsoft/playwright/impl/StackTraceCollector.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java b/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java index f137b8ac0..af6e26b47 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java @@ -69,7 +69,13 @@ private String sourceFile(StackTraceElement frame) { if (file == null) { return ""; } - return resolveSourcePath(Paths.get(pkg).resolve(file)); + try { + // The file name can contain an arbitrary string which may cause Path implementation + // to throw. See https://github.com/microsoft/playwright-java/issues/1115 + return resolveSourcePath(Paths.get(pkg).resolve(file)); + } catch (RuntimeException e) { + return ""; + } } private String resolveSourcePath(Path relativePath) {