From e2cbb7e3ffc7e0658124278b555ed7a41d52fbf2 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 8 Jul 2020 10:45:50 +0200 Subject: [PATCH 1/3] ci: test also on Python 3.7 --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8f213a5cf..34c13d0ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, windows-latest, macos-latest] + python-version: [3.7, 3.8] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v2 @@ -29,7 +30,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v2 with: - python-version: 3.8 + python-version: ${{ matrix.python-version }} - name: Install dependencies run: | python -m pip install --upgrade pip From c37f863f6d3a5f68a1b57e47b73a0fb63546c141 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 8 Jul 2020 11:49:30 +0200 Subject: [PATCH 2/3] fix: event loop for Windows --- playwright/playwright.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/playwright/playwright.py b/playwright/playwright.py index 9723fa625..0246861a2 100644 --- a/playwright/playwright.py +++ b/playwright/playwright.py @@ -27,6 +27,9 @@ class Playwright: def __init__(self) -> None: + if sys.platform == 'win32': + loop = asyncio.ProactorEventLoop() + asyncio.set_event_loop(loop) self.loop = asyncio.get_event_loop() self.loop.run_until_complete(self._sync_init()) From 526b31f799d1b8376fcdcc48da8267b52d0698da Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 8 Jul 2020 17:32:59 +0200 Subject: [PATCH 3/3] fix: build package --- local-requirements.txt | 2 ++ setup.py | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/local-requirements.txt b/local-requirements.txt index bd703a91d..d1a2d1776 100644 --- a/local-requirements.txt +++ b/local-requirements.txt @@ -2,3 +2,5 @@ pytest==5.4.3 pytest-asyncio==0.14.0 pytest-cov==2.10.0 mypy==0.782 +setuptools==49.1.0 +wheel==0.34.2 diff --git a/setup.py b/setup.py index ccb608078..065aded95 100644 --- a/setup.py +++ b/setup.py @@ -33,7 +33,12 @@ 'typing-extensions', ], classifiers=[ + 'Topic :: Software Development :: Testing', + 'Topic :: Internet :: WWW/HTTP :: Browsers', + 'Intended Audience :: Developers', 'Programming Language :: Python :: 3', + 'Programming Language :: Python :: 3.7', + 'Programming Language :: Python :: 3.8', 'License :: OSI Approved :: Apache Software License', 'Operating System :: OS Independent', ],