From 11f33b5c5a7d6a919f109df90c33be573570bc39 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Mon, 4 Dec 2023 13:01:22 -0800 Subject: [PATCH] Remove some nowaitfor --- tests/page/interception.spec.ts | 2 +- tests/page/page-route.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/page/interception.spec.ts b/tests/page/interception.spec.ts index 05233ea5e386d..c381e9f6e34f2 100644 --- a/tests/page/interception.spec.ts +++ b/tests/page/interception.spec.ts @@ -52,7 +52,7 @@ it('should intercept after a service worker', async ({ page, server, browserName contentType: 'text/css', body: 'responseFromInterception:' + name }); - }, { noWaitForFinish: true }); + }); // Page route is applied after service worker fetch event. const swResponse2 = await page.evaluate(() => window['fetchDummy']('foo')); diff --git a/tests/page/page-route.spec.ts b/tests/page/page-route.spec.ts index 7e870fadceb61..49546dc55a65b 100644 --- a/tests/page/page-route.spec.ts +++ b/tests/page/page-route.spec.ts @@ -264,7 +264,7 @@ it('should show custom HTTP headers', async ({ page, server }) => { it('should work with redirect inside sync XHR', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); server.setRedirect('/logo.png', '/pptr.png'); - await page.route('**/*', route => route.continue(), { noWaitForFinish: true }); + await page.route('**/*', route => route.continue()); const status = await page.evaluate(async () => { const request = new XMLHttpRequest(); request.open('GET', '/logo.png', false); // `false` makes the request synchronous