From 6f0923bdea0b201ac6234df84da0901147128355 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 18 May 2021 02:11:07 -0700 Subject: [PATCH] fix(release-1.11): fix tests after cherry-pick --- tests/chromium/chromium.spec.ts | 47 +++++++++++++++++---------------- 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/tests/chromium/chromium.spec.ts b/tests/chromium/chromium.spec.ts index 8d0cc8ce20b6a..ff1a4fa934721 100644 --- a/tests/chromium/chromium.spec.ts +++ b/tests/chromium/chromium.spec.ts @@ -245,31 +245,32 @@ playwrightTest.describe('chromium', () => { expect(request.headers['foo']).toBe('bar'); } }); -}); -playwrightTest('should report all pages in an existing browser', async ({ browserType, browserOptions }, testInfo) => { - const port = 9339 + testInfo.workerIndex; - const browserServer = await browserType.launch({ - ...browserOptions, - args: ['--remote-debugging-port=' + port] - }); - try { - const cdpBrowser = await browserType.connectOverCDP({ - endpointURL: `http://localhost:${port}/`, + playwrightTest('should report all pages in an existing browser', async ({ browserType, browserOptions }, testInfo) => { + const port = 9339 + testInfo.workerIndex; + const browserServer = await browserType.launch({ + ...browserOptions, + args: ['--remote-debugging-port=' + port] }); - const contexts = cdpBrowser.contexts(); - expect(contexts.length).toBe(1); - for (let i = 0; i < 3; i++) - await contexts[0].newPage(); - await cdpBrowser.close(); + try { + const cdpBrowser = await browserType.connectOverCDP({ + endpointURL: `http://localhost:${port}/`, + }); + const contexts = cdpBrowser.contexts(); + expect(contexts.length).toBe(1); + for (let i = 0; i < 3; i++) + await contexts[0].newPage(); + await cdpBrowser.close(); - const cdpBrowser2 = await browserType.connectOverCDP({ - endpointURL: `http://localhost:${port}/`, - }); - expect(cdpBrowser2.contexts()[0].pages().length).toBe(3); + const cdpBrowser2 = await browserType.connectOverCDP({ + endpointURL: `http://localhost:${port}/`, + }); + expect(cdpBrowser2.contexts()[0].pages().length).toBe(3); - await cdpBrowser2.close(); - } finally { - await browserServer.close(); - } + await cdpBrowser2.close(); + } finally { + await browserServer.close(); + } + }); }); +