From 8ebe4dc81ab99a7ca65aa798bf81d22d072f0225 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 23 May 2023 02:21:09 +0000 Subject: [PATCH] devops: do not use NPX during docker container build (#23213) The postmortem of the broken docker image: - We use `playwright-core` package when bootstrapping our docker container. - Due to accidental removal of `bin` entry in the `playwright-core` (see https://github.com/microsoft/playwright/issues/23206), the `npx playwright install --with-deps` was using the last published Playwright version instead of a locally-built playwright binary This patch starts using `npx exec --no` to make sure that we never call remote commands during docker image build. --- utils/docker/Dockerfile.focal | 4 ++-- utils/docker/Dockerfile.jammy | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/utils/docker/Dockerfile.focal b/utils/docker/Dockerfile.focal index e870a5e46066f..4a9811d850920 100644 --- a/utils/docker/Dockerfile.focal +++ b/utils/docker/Dockerfile.focal @@ -37,7 +37,7 @@ RUN mkdir /ms-playwright && \ mkdir /ms-playwright-agent && \ cd /ms-playwright-agent && npm init -y && \ npm i /tmp/playwright-core.tar.gz && \ - npx playwright mark-docker-image "${DOCKER_IMAGE_NAME_TEMPLATE}" && \ - npx playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \ + npm exec --no -- playwright mark-docker-image "${DOCKER_IMAGE_NAME_TEMPLATE}" && \ + npm exec --no -- playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \ rm /tmp/playwright-core.tar.gz && \ chmod -R 777 /ms-playwright diff --git a/utils/docker/Dockerfile.jammy b/utils/docker/Dockerfile.jammy index 57507a1870ed5..ca282ce18ea0f 100644 --- a/utils/docker/Dockerfile.jammy +++ b/utils/docker/Dockerfile.jammy @@ -35,8 +35,8 @@ RUN mkdir /ms-playwright && \ mkdir /ms-playwright-agent && \ cd /ms-playwright-agent && npm init -y && \ npm i /tmp/playwright-core.tar.gz && \ - npx playwright mark-docker-image "${DOCKER_IMAGE_NAME_TEMPLATE}" && \ - npx playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \ + npm exec --no -- playwright mark-docker-image "${DOCKER_IMAGE_NAME_TEMPLATE}" && \ + npm exec --no -- playwright install --with-deps && rm -rf /var/lib/apt/lists/* && \ rm /tmp/playwright-core.tar.gz && \ rm -rf /ms-playwright-agent && \ chmod -R 777 /ms-playwright