Skip to content

Commit

Permalink
devops: run install tests on common node versions (#2069)
Browse files Browse the repository at this point in the history
Fixes #2059
  • Loading branch information
rwoll committed May 1, 2020
1 parent d7a1e01 commit 995c3eb
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/tests.yml
Expand Up @@ -270,13 +270,17 @@ jobs:

test-package-installations:
runs-on: ubuntu-latest
strategy:
matrix:
node_version:
- "^10.17.0" # pre 10.17, --unhandled-rejections=strict was not an option (https://github.com/nodejs/node/pull/26599) which we need in our tests
- "^12.0.0"
- "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988)
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
# New node.js version supports `--unhandled-rejections=strict` flag that
# we use in `installation-tests.sh`.
node-version: 12
node-version: ${{ matrix.node_version }}
- uses: microsoft/playwright-github-action@v1
- run: npm ci
- run: bash test/installation-tests/installation-tests.sh

0 comments on commit 995c3eb

Please sign in to comment.