From 995c3eb4b5f3a9b0cdb449365bfbce130688b835 Mon Sep 17 00:00:00 2001 From: Ross Wollman Date: Fri, 1 May 2020 00:10:52 -0700 Subject: [PATCH] devops: run install tests on common node versions (#2069) Fixes #2059 --- .github/workflows/tests.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index aaf64da998a4a..d070e9095977f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -270,13 +270,17 @@ jobs: test-package-installations: runs-on: ubuntu-latest + strategy: + matrix: + node_version: + - "^10.17.0" # pre 10.17, --unhandled-rejections=strict was not an option (https://github.com/nodejs/node/pull/26599) which we need in our tests + - "^12.0.0" + - "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988) steps: - uses: actions/checkout@v2 - uses: actions/setup-node@v1 with: - # New node.js version supports `--unhandled-rejections=strict` flag that - # we use in `installation-tests.sh`. - node-version: 12 + node-version: ${{ matrix.node_version }} - uses: microsoft/playwright-github-action@v1 - run: npm ci - run: bash test/installation-tests/installation-tests.sh