From f096b39db2b94ddcacde126b765c682472e0f9ae Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Wed, 1 Dec 2021 11:35:22 -0800 Subject: [PATCH] fix(click): revert layout shift logic --- packages/playwright-core/src/server/dom.ts | 2 +- tests/hit-target.spec.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/dom.ts b/packages/playwright-core/src/server/dom.ts index 18545e677fbc0..9a261d50a16d2 100644 --- a/packages/playwright-core/src/server/dom.ts +++ b/packages/playwright-core/src/server/dom.ts @@ -407,7 +407,7 @@ export class ElementHandle extends js.JSHandle { const point = roundPoint(maybePoint); progress.metadata.point = point; - if (process.env.PLAYWRIGHT_NO_LAYOUT_SHIFT_CHECK) + if (!process.env.PLAYWRIGHT_LAYOUT_SHIFT_CHECK) return this._finishPointerAction(progress, actionName, point, options, action); else return this._finishPointerActionDetectLayoutShift(progress, actionName, point, options, action); diff --git a/tests/hit-target.spec.ts b/tests/hit-target.spec.ts index 04f857e3eb29f..8ea2f77d77eee 100644 --- a/tests/hit-target.spec.ts +++ b/tests/hit-target.spec.ts @@ -45,6 +45,8 @@ it('should block all events when hit target is wrong', async ({ page, server }) }); it('should block click when mousedown succeeds but mouseup fails', async ({ page, server }) => { + it.fixme(); + await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => { button.addEventListener('mousedown', () => { @@ -82,6 +84,8 @@ it('should click when element detaches in mousedown', async ({ page, server }) = }); it('should not block programmatic events', async ({ page, server }) => { + it.fixme(); + await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => { button.addEventListener('mousedown', () => {