-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] ffmpeg dependency check fails on Linux #3845
Comments
@yury-s, @aslushnikov - I believe this issue would be fixed if we bundled ffmpeg for Linux as well with the NPM package (as we have for Windows/macOS). Is it possible to do that? I'm a bit hesitant to make ffmpeg an optional dependency since screencast is a highly requested user feature. |
Agreed. Bundling would be a better solution. |
anthonychu
added a commit
to anthonychu/functions-headless-chromium
that referenced
this issue
Sep 11, 2020
aslushnikov
added a commit
that referenced
this issue
Sep 15, 2020
This patch bakes ffmpeg-linux r1001 into our NPM package. This increases NPM package size from 4.2MB to 6.7MB. Fixes #3845
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
Sep 15, 2020
This was referenced Sep 15, 2020
aslushnikov
added a commit
that referenced
this issue
Sep 15, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this issue
Sep 15, 2020
Cherry-pick: - PR microsoft#3882 SHA 430f2be References microsoft#3845
aslushnikov
added a commit
that referenced
this issue
Sep 16, 2020
ianschmitz
added a commit
to vertigis/vertigis-web-sdk
that referenced
this issue
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context:
The new ffmpeg dependency check is a breaking change on Linux because it now expects ffmpeg in the path. Is it possible to only run the check when video recording is activated?
Code Snippet
This app, with the playwright version bumped to 1.4.0. https://github.com/anthonychu/functions-headless-chromium/tree/main/playwright
@arjun27
The text was updated successfully, but these errors were encountered: