Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to npx playwright-core install when using core #23260

Merged
merged 1 commit into from May 24, 2023

Conversation

pavelfeldman
Copy link
Member

No description provided.

@pavelfeldman pavelfeldman merged commit 64dde29 into microsoft:main May 24, 2023
6 checks passed
@dominikg
Copy link

dominikg commented May 29, 2023

@pavelfeldman i think this is a breaking change. Prior to this, you could pnpm playwright install chromium in ci scripts because the playwright bin was automatically resolved.

Example: https://github.com/sveltejs/vite-plugin-svelte/actions/runs/5113458686/jobs/9192684740?pr=669#step:9:8
This renovate bot PR updates playwright-core to 1.34 and the action fails due to the inability to run the install command.

MurakamiShinyu added a commit to vivliostyle/vivliostyle-cli that referenced this pull request May 31, 2023
This change is necessary because of the change in playwright v1.34.3.
see microsoft/playwright#23260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants