Skip to content

feat(webkit): roll webkit to r1301 #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2020
Merged

feat(webkit): roll webkit to r1301 #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc86dbe
feat(webkit): roll webkit to r1301
aslushnikov Jul 3, 2020
e905e59
fixxxit
aslushnikov Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browsers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"name": "webkit",
"revision": "1298"
"revision": "1301"
}
]
}
4 changes: 2 additions & 2 deletions test/headful.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

const utils = require('./utils');
const { makeUserDataDir, removeUserDataDir } = utils;
const {FFOX, CHROMIUM, WEBKIT, WIN} = utils.testOptions(browserType);
const {FFOX, CHROMIUM, WEBKIT, WIN, MAC} = utils.testOptions(browserType);

describe('Headful', function() {
it('should have default url when launching browser', async ({browserType, defaultBrowserOptions}) => {
Expand Down Expand Up @@ -79,7 +79,7 @@ describe('Headful', function() {
await page.click('button');
await browser.close();
});
it.fail(CHROMIUM || (WEBKIT && WIN))('should close browser after context menu was triggered', async({browserType, defaultBrowserOptions, server}) => {
it.fail(CHROMIUM && MAC)('should close browser after context menu was triggered', async({browserType, defaultBrowserOptions, server}) => {
const browser = await browserType.launch({...defaultBrowserOptions, headless: false });
const page = await browser.newPage();
await page.goto(server.PREFIX + '/grid.html');
Expand Down