fix(mcp): disconnect tracked browser on BrowserTracker.dispose#40967
Open
Skn0tt wants to merge 1 commit into
Open
fix(mcp): disconnect tracked browser on BrowserTracker.dispose#40967Skn0tt wants to merge 1 commit into
Skn0tt wants to merge 1 commit into
Conversation
The dashboard's BrowserTracker opens a remote Playwright connection to each bound daemon browser but never closes it on dispose. The WS to the daemon lingers until the dashboard process exits, keeping client-driven subscriptions (e.g. screencast) alive on the daemon side longer than they need to be.
Contributor
Test results for "MCP"1 failed 7180 passed, 1113 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BrowserTrackeropens a remote Playwright connection to each bound daemon browser but never closes it on dispose, leaking the WS (and any client-driven subscriptions on it, e.g. screencast) until the dashboard process exits.browser.close()at the end ofdispose().Suspected contributor to the ~30s
cli show --killdurations seen in MCP Windows Firefox CI jobs (e.g. https://github.com/microsoft/playwright/actions/runs/26235830215/job/77208610752), where the dashboard'sgracefullyProcessExitDoNotHang30s force-exit timer wins because cleanup didn't run.