fix(network): use internal methods in HarTracer#41186
Merged
Merged
Conversation
Publicly-facing methods like `Response.sizes()` throw upon page closure. This makes ongoing har recording in the trace to sometimes throw an internal error instead of handling the page closure gracefully. Fixes the `TargetClosedError: Test ended` flaky error on tracing bots.
Contributor
Test results for "MCP"7266 passed, 1119 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 flaky39521 passed, 774 skipped Merge workflow run. |
Skn0tt
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publicly-facing methods like
Response.sizes()throw upon page closure. This makes ongoing har recording in the trace to sometimes throw an internal error instead of handling the page closure gracefully.Fixes the
TargetClosedError: Test endedflaky error on tracing bots that started after #40893.