feat(codegen): allow generating tests#7049
Merged
Merged
Conversation
JoelEinbinder
approved these changes
Jun 10, 2021
| if (this._isTest) | ||
| formatter.add(` expect(${pageAlias}.url()).toBe(${quote(signals.assertNavigation.url)});`); | ||
| else | ||
| formatter.add(` // assert.equal(${pageAlias}.url(), ${quote(signals.assertNavigation.url)});`); |
Contributor
There was a problem hiding this comment.
Maybe remove the asserts? We have tests with expect for people now.
Member
Author
There was a problem hiding this comment.
Yes, I did it and then test started failing and i don't want to fix it for merge. Will follow up.
pavelfeldman
added a commit
to pavelfeldman/playwright
that referenced
this pull request
Jun 11, 2021
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Jun 11, 2021
- Cherry-Pick PR microsoft#7049 SHA 3b1bae8 - Cherry-Pick PR microsoft#7069 SHA afa9d69 Fixes microsoft#7020
aslushnikov
added a commit
that referenced
this pull request
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7020