Fix macOS framework settings

microsoft · Jun 25, 2020 · e61bcf8 · e61bcf8
1 parent ce42bb7
commit e61bcf8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/CrashReporter.xcodeproj/project.pbxproj b/CrashReporter.xcodeproj/project.pbxproj
@@ -3730,9 +3730,11 @@
 					"$(inherited)",
 					"-DPLCF_MIN_MACOSX_SDK=$(PL_MIN_MACOSX_SDK)",
 				);
+				OTHER_LDFLAGS = "-ObjC";
 				PRELINK_FLAGS = "-w";
 				PRELINK_LIBS = "$(CONFIGURATION_BUILD_DIR)/lib$(PRODUCT_NAME).a";
 				SDKROOT = macosx;
+				SKIP_INSTALL = YES;
 			};
 			name = Debug;
 		};
@@ -3751,9 +3753,11 @@
 					"$(inherited)",
 					"-DPLCF_MIN_MACOSX_SDK=$(PL_MIN_MACOSX_SDK)",
 				);
+				OTHER_LDFLAGS = "-ObjC";
 				PRELINK_FLAGS = "-w";
 				PRELINK_LIBS = "$(CONFIGURATION_BUILD_DIR)/lib$(PRODUCT_NAME).a";
 				SDKROOT = macosx;
+				SKIP_INSTALL = YES;
 			};
 			name = Release;
 		};

diff --git a/Other Sources/Crash Demo/main.m b/Other Sources/Crash Demo/main.m
@@ -115,10 +115,7 @@ static void save_crash_report (PLCrashReporter *reporter) {
  * enabled.
  */
 static bool debugger_should_exit (void) {
-#if !TARGET_OS_IPHONE
-    return false;
-#endif
-
+#if TARGET_OS_IPHONE
     struct kinfo_proc info;
     size_t info_size = sizeof(info);
     int name[4];
@@ -135,7 +132,7 @@ static bool debugger_should_exit (void) {
 
     if ((info.kp_proc.p_flag & P_TRACED) != 0)
         return true;
-    
+#endif
     return false;
 }
 

diff --git a/Resources/DemoCrash-macOS-Info.plist b/Resources/DemoCrash-macOS-Info.plist
@@ -20,6 +20,8 @@
 	<string>1.0</string>
 	<key>CFBundleShortVersionString</key>
 	<string>1.0</string>
+	<key>LSApplicationCategoryType</key>
+	<string>public.app-category.developer-tools</string>
 	<key>NSMainNibFile</key>
 	<string>MainMenu</string>
 	<key>NSPrincipalClass</key>