Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup build and short versions #66

Merged
merged 2 commits into from Mar 25, 2020
Merged

Setup build and short versions #66

merged 2 commits into from Mar 25, 2020

Conversation

@AnastasiaKubova
Copy link
Contributor

AnastasiaKubova commented Mar 25, 2020

In Xcode 10 the CURRENT_PROJECT_VERSION meant CFBundleShortVersionString. But in Xcode 11 it is changed and use for CFBundleVersion and for CFBundleShortVersionString
use MARKETING_VERSION.
In the project in Xcode 11 the CFBundleShortVersionString value was null because the MARKETING_VERSION did not exist in Xcode 10.

This changes are setting in CFBundleShortVersionString and CFBundleVersion the same values from CURRENT_PROJECT_VERSION.

AB#77612

@MatkovIvan MatkovIvan marked this pull request as ready for review Mar 25, 2020
@MatkovIvan MatkovIvan requested a review from iamclement Mar 25, 2020
@iamclement iamclement merged commit 06fc489 into master Mar 25, 2020
2 checks passed
2 checks passed
Build PLCrashReporter for all platforms #20200325.4 succeeded
Details
license/cla All CLA requirements met.
@iamclement iamclement deleted the fix/update-build-version branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.