From e27e3cd3a792435de42081a2763ee56c57a8ed05 Mon Sep 17 00:00:00 2001 From: Wei Wei Date: Thu, 8 Nov 2018 15:29:19 +0800 Subject: [PATCH 1/2] Prevent selecting rows without key Rows without key are non-selectable. The selection API should protect user from doing that. --- js/vnext/projection/selection.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/js/vnext/projection/selection.js b/js/vnext/projection/selection.js index ec56bb0..f60c2fe 100644 --- a/js/vnext/projection/selection.js +++ b/js/vnext/projection/selection.js @@ -24,10 +24,12 @@ function changeSelectAll(e) { } export function setSelectRow(gridView, key, checked) { - const { resolver } = gridView.get('selection'); - const selection = checked ? resolver.selectRow(key) : resolver.deselectRow(key); + if (key !== null && key !== undefined) { + const { resolver } = gridView.get('selection'); + const selection = checked ? resolver.selectRow(key) : resolver.deselectRow(key); - updateSelection(gridView, selection); + updateSelection(gridView, selection); + } } function changeSelectRow(e) { From d5f583e945c910667ec60a60fa3987448202e6e9 Mon Sep 17 00:00:00 2001 From: Wei Wei Date: Thu, 8 Nov 2018 15:31:31 +0800 Subject: [PATCH 2/2] Bump version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index d57cdb4..8ef337c 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,7 @@ "name": "Ahmed Kamel" }, "main": "dist/projection-grid.js", - "version": "0.1.11", + "version": "0.1.12", "files": [ "dist" ],