Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure][bugfix] Fix Azure replay test wrong sanitizations #3404

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jun 12, 2024

Description

#3390 introduces some sanitizations, which breaks promptflow-azure replay test. This PR targets to add an environment variable to distinguish promptflow-azure and promptflow-evals.

Besides, make promptflow-azure replay test listen on pf-recording code path to avoid such breaking.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/bugfix/azure-replay-test

  4 files    4 suites   4m 18s ⏱️
243 tests 203 ✅  40 💤 0 ❌
972 runs  812 ✅ 160 💤 0 ❌

Results for commit 6727346.

Copy link

SDK CLI Global Config Test Result zhengfei/bugfix/azure-replay-test

6 tests   6 ✅  1m 15s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 6727346.

Copy link

SDK CLI Test Result zhengfei/bugfix/azure-replay-test

    4 files      4 suites   1h 6m 18s ⏱️
  784 tests   764 ✅ 20 💤 0 ❌
3 136 runs  3 056 ✅ 80 💤 0 ❌

Results for commit 6727346.

@wangchao1230 wangchao1230 merged commit 09ac0af into main Jun 12, 2024
29 checks passed
@wangchao1230 wangchao1230 deleted the zhengfei/bugfix/azure-replay-test branch June 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants