Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom pydevd event to support InputRequested #1546

Merged

Conversation

Projects
None yet
3 participants
@karthiknadig
Copy link
Member

commented Jul 1, 2019

This Fixes #1523 in a way that it adds a custom event so that there is always a name for the event.

This also addresses Fixes #1497, Fixes #1496. Those events don't need additional work, and they can be forwarded in their current state.

@karthiknadig karthiknadig requested a review from int19h Jul 1, 2019

self.kwargs = kwargs


def to_dict(self, update_ids_to_dap=False): # noqa (update_ids_to_dap may be unused)

This comment has been minimized.

Copy link
@int19h

int19h Jul 1, 2019

Contributor

I think you can use _ as variable name to suppress the unused warning without having to write the comment.

This comment has been minimized.

Copy link
@fabioz

fabioz Jul 1, 2019

Collaborator

This isn't really possible because it wouldn't follow what's expected from the API (callers expect the parameter to be update_ids_to_dap).

@int19h

int19h approved these changes Jul 1, 2019

@fabioz

fabioz approved these changes Jul 1, 2019

@karthiknadig karthiknadig merged commit 833011d into microsoft:dbg_adapter_refactor Jul 1, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
license/cla All CLA requirements met.
Details

@karthiknadig karthiknadig deleted the karthiknadig:refactor2 branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.